Reenable Code based profiling when VM Developer Mode is enabled #8832
Conversation
| @@ -1 +1 @@ | |||
| 7313c873463d2a20a7ec1047d7b8b9146dd2a39b | |||
| de872dd864518d436062354052ea8604c38e8c94 | |||
There was a problem hiding this comment.
is this intentional? @elliette just submitted a PR this morning that updated this to the latest
There was a problem hiding this comment.
Yes, this is intentional. 7313c873463d2a20a7ec1047d7b8b9146dd2a39b points to a change from two days ago that doesn't include the vm_service version bump.
| found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd. | ||
| --> | ||
| ## 0.3.1 | ||
| * Add "Supported Flutter versions" policy to the README. |
There was a problem hiding this comment.
was this one supposed to move up to 0.3.1?
There was a problem hiding this comment.
I thought it wasn't included in the release notes for 0.3.0 so I included it here. I must have been looking at the wrong package on Pub.
| string_scanner: ^1.1.0 | ||
| unified_analytics: ^7.0.0 | ||
| vm_service: '>=13.0.0 <16.0.0' | ||
| vm_service: ">=15.0.0 <16.0.0" |
There was a problem hiding this comment.
does 15.0.0 come with a min sdk version bump?
There was a problem hiding this comment.
No, since it wasn't a change in the service protocol. There's a breaking change in package:vm_service where Code.function is no longer FuncRef but dynamic since it can also be a NativeFunction. This impacts code in DevTools, which is why I'm raising the lower bound to the newest compatible version.
|
Ahh is this why I was seeing errors on https://dart-review.googlesource.com/c/sdk/+/407141? Do I need to prepare the release with Flutter version de872dd864518d436062354052ea8604c38e8c94 instead? |
Yep, that's what's causing the |
3 participants
Fixes #8567
Also prepares
package:devtools_app_sharedandpackage:devtools_extensionsfor a new release containing the updatedpackage:vm_serviceconstraints. This is needed to resolve analysis failures on theflutter-analyze-trybot in the SDK.